-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify site generation #1166
Simplify site generation #1166
Conversation
I pulled logging-log4j-tools and built it. I ran mvn clean install (which worked). I then ran mvn site, which failed with
|
@rgoers, it simply works on my machine. Since Would you mind trying Which module fails to build? |
It fails at the root of the project. It isn't in any module. |
@rgoers: my guess is that you are using a Maven Central mirror that does not contain the |
It turns out I had some Spring repos in my settings.xml from when I was adding out stuff to Spring and that messed it up. After removing it the site built fine and only took 47 seconds! However, I still have to look at the results. |
Under components, when I select "Implementation" I get a file not found. All the other pages are fine. Note - make sure you do |
I have removed that page, since it was empty anyway. Now, in c612522, removed it from the menu too.
✔️ |
c612522
to
f1ee3a6
Compare
…VersionMajor>` pattern.
f1ee3a6
to
fc40fdd
Compare
Warning! These changes are based on the work delivered in #1145 replacing the
maven-changes-plugin
. Hence, that PR needs to be merged first!This PR attempts to simplify the site generation.
Highlights from the changes are as follows:
enforce-upper-bound-deps
Maven enforcer rule is fixed/pom.xml
is overhauled (developers
are simplified,contributors
are removed, unused configurations/properties are removed, etc.)maven-site-plugin
is disabled for all modules except/pom.xml
<module>/src/site/markdown/index.md[.vm]
files are moved to/src/site/markdown/<module>.md[.vm]
As a result,
./mvnw site
takes less than 30s on a decent laptop.