Skip the transformer if log4j-api isn't present #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
approved these changes
Oct 15, 2024
Contributor
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
LGTM
I left a couple of comments below.
...nsform-maven-plugin/src/main/java/org/apache/logging/log4j/transform/maven/LocationMojo.java
Show resolved
Hide resolved
...nsform-maven-plugin/src/main/java/org/apache/logging/log4j/transform/maven/LocationMojo.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ralph Goers <rgoers@apache.org>
rgoers
force-pushed
the
skip-with-no-log4j
branch
from
d0bca5b to
fbf2ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will exit the plugin with an info message if log4j-api is not present.