Add example to test transitive compile-time dependencies in Gradle #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
force-pushed
the
add-gradle-metadata-example
branch
3 times, most recently
from
4799c71 to
2fbeaf0
Compare
vy
reviewed
Mar 2, 2025
log4j-samples-gradle-metadata/gradle/wrapper/gradle-wrapper.jar
Outdated
Show resolved
Hide resolved
vy
reviewed
Mar 2, 2025
|
@ppkarwasz, I'd appreciate if we can co-review this one. Would you mind sharing your thoughts, please? |
ppkarwasz
reviewed
Mar 3, 2025
jjohannes
force-pushed
the
add-gradle-metadata-example
branch
from
2fbeaf0 to
b562081
Compare
jjohannes
force-pushed
the
add-gradle-metadata-example
branch
from
b562081 to
853fd87
Compare
ppkarwasz
approved these changes
Apr 9, 2025
jjohannes
force-pushed
the
add-gradle-metadata-example
branch
from
853fd87 to
bdce04c
Compare
jjohannes
commented
Apr 10, 2025
jjohannes
force-pushed
the
add-gradle-metadata-example
branch
from
bdce04c to
4fd2a25
Compare
This adds an example that show that the Gradle Metadata published for Log4j has the desired effect on the compile classpath when Log4j is used in Gradle builds. This changes the "Android test pipeline" to a "Gradle test pipeline" to run all Gradle-based tests. Which are at the moment the "Android test" and this newly added test. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes
force-pushed
the
add-gradle-metadata-example
branch
from
4fd2a25 to
bf205b7
Compare
ppkarwasz
requested changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an example that show that the Gradle Metadata published for Log4j has the desired effect on the compile classpath when Log4j is used in Gradle builds.
See: apache/logging-log4j2#3437
This changes the "Android test pipeline" to a "Gradle test pipeline" to run all Gradle-based tests. Which are at the moment the "Android test" and this newly added test.