Skip to content

[BugFix] Fix MySQL getPrimaryKeys database name error (#5235) - #5471

Open
zhang-arvin wants to merge 1 commit into
apache:masterfrom
zhang-arvin:fix/5235-mysql-getPrimaryKeys-database
Open

zhang-arvin wants to merge 1 commit into
apache:masterfrom
zhang-arvin:fix/5235-mysql-getPrimaryKeys-database

Conversation

@zhang-arvin

Copy link
Copy Markdown

Closes #5235

…ect database name' error (apache#5235)

- Add database field to AbstractSqlConnection and pass it to getPrimaryKeys
- Update mysql/SqlConnection in metadata-query to pass database parameter
- Update mysql/SqlConnection in datasource-manager to pass database parameter
- Fixes: dbMeta.getPrimaryKeys(null, null, table) -> getPrimaryKeys(database, null, table)
@zhang-arvin

Copy link
Copy Markdown
Author

Base-branch note: the failing checks are not caused by this PR.

All of sql-check, spotless-check, third-party-dependencies-check and build-backend fail on files that this PR does not touch, and they fail identically on the other open PRs from the same branch point. The failures come from master itself:

None of these files appears in this PR's diff, so there is nothing on this PR to fix here; it will go green once master is repaired. This PR stays on the master baseline problem until that lands.

This comment was generated by an AI agent (Hermes Agent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Incorrect database name

1 participant