allow specifying standard as a domain in ex_associate_address_with_node#335
Closed
zerthimon wants to merge 1 commit intoapache:trunkfrom
zerthimon:use_standard_domain
Closed
allow specifying standard as a domain in ex_associate_address_with_node#335zerthimon wants to merge 1 commit intoapache:trunkfrom zerthimon:use_standard_domain
zerthimon wants to merge 1 commit intoapache:trunkfrom
zerthimon:use_standard_domain
Conversation
Contributor
Author
|
Something went wrong with the travis tests. Is there a way to tell it to recheck ? |
Contributor
|
Yes, you can push an empty commit to the branch by using |
Contributor
|
Looks good to me, but get the tests to work first, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS uses "domain" field to distinguish between EIPs allocated for Classic EC2 ('standard') and EIPs allocated for VPC (value 'vpc')
domain
Indicates whether this Elastic IP address is for use with instances in EC2-Classic (standard) or instances in a VPC (vpc).
Type: xsd:string
Valid values: standard | vpc
http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-ItemType-DescribeAddressesResponseItemType.html
The method ex_allocate_address() also uses 'standard' and 'vpc' as allowed parameters.
This patch adds 'standard' as a value to domain parameter.
None is left for backward compatibility.