LIBCLOUD-590 - Reduce redundant API calls of CloudStack compute driver's...

[atsaki]

CloudStack compute driver's list_nodes method executes too many API calls and it slows down this method.
The patch reduces redundant API calls and speed up list_nodes method.

https://issues.apache.org/jira/browse/LIBCLOUD-590

[sebgoa]

thanks for your patches, I am a bit busy this coming days, but I will try to comment/merge as soon as possible.

[allardhoeve]

This looks to broad to me. What does it catch? Why would you catch all the things and not fail here?

[allardhoeve]

This is a complex function that can be broken down into smaller bits to make it much more legible. That is not the scope of the PR though.

I think this is fine, but we could actually use some more tests here. The lack of tests makes me hesitant to merge it. I would be much more comfortable if the test_list_nodes method contained at least an entry that has the correct IPs. I would like to see these added to the tests with their expected contents:

1. node.extra['ip_addresses']
2. node.extra['ip_forwarding_rules']
3. node.extra['port_forwarding_rules']

[sebgoa]

@atsaki do you plan to work on this ? @allardhoeve made some good comments, could you answer ?thanks

[allardhoeve]

My comments still stand ofcourse.

[atsaki]

I'm working on this. Please wait for a few days.

[atsaki]

I updated the code to follow the comments.
Can you check them?

[allardhoeve]

Thanks.

This is better than before.

I have no access to CloudStack, so I can't test this and I also don't feel qualified to plus one it.

[sebgoa]

@atsaki this was closed by mistake as we are trying to close some old PRs. Can you reopen again, I will merge this week.

[atsaki]

@Runseb I reopened #641.