-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trunk #3
Closed
Closed
Trunk #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your patch! This has been fixed in r1054119. |
Great, thanks! |
rphillips
pushed a commit
to rphillips/libcloud
that referenced
this pull request
Oct 6, 2011
Notification Plan Bug Fix
Phreedom
added a commit
to Phreedom/libcloud
that referenced
this pull request
Jun 30, 2014
…argetpool: multiple bugfixes Fix apache#1: targetpool = driver.ex_get_targetpool('tpname') targetpool.add_node(node) node.destroy() # targetpool still contains the node targetpool = driver.ex_get_targetpool('tpname') # targetpool.nodes contains node uri string (in addition to possible other node objects) # as produced by _to_targetpool because the node is in the pool but is destroyed targetpool.remove_node(node) # raises an exception, removes the node nevertheless. Expected behavior: remove the node, return true Fix apache#2: targetpool.add(node) targetpool.add(node) # targetpool.nodes contains 2 copies of node # actual targetpool resource on the GCE side doesn't contain 2 copies Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side Fix/Improvement apache#3: Allow specifying nodes by fully-qualified node uri in add_node and remove_node. if tp.nodes: tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist exoected behavior: should be able to remove any node from the list GCE allows adding non-existent nodes to the targetpool and doesn't automatically remove nodes from the pool if you delete them. libcloud should support doing the same.
Phreedom
added a commit
to Phreedom/libcloud
that referenced
this pull request
Sep 16, 2014
…argetpool: multiple bugfixes Fix apache#1: targetpool = driver.ex_get_targetpool('tpname') targetpool.add_node(node) node.destroy() # targetpool still contains the node targetpool = driver.ex_get_targetpool('tpname') # targetpool.nodes contains node uri string (in addition to possible other node objects) # as produced by _to_targetpool because the node is in the pool but is destroyed targetpool.remove_node(node) # raises an exception, removes the node nevertheless. Expected behavior: remove the node, return true Fix apache#2: targetpool.add(node) targetpool.add(node) # targetpool.nodes contains 2 copies of node # actual targetpool resource on the GCE side doesn't contain 2 copies Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side Fix/Improvement apache#3: Allow specifying nodes by fully-qualified node uri in add_node and remove_node. if tp.nodes: tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist exoected behavior: should be able to remove any node from the list GCE allows adding non-existent nodes to the targetpool and doesn't automatically remove nodes from the pool if you delete them. libcloud should support doing the same.
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2014
…argetpool: multiple bugfixes Fix #1: targetpool = driver.ex_get_targetpool('tpname') targetpool.add_node(node) node.destroy() # targetpool still contains the node targetpool = driver.ex_get_targetpool('tpname') # targetpool.nodes contains node uri string (in addition to possible other node objects) # as produced by _to_targetpool because the node is in the pool but is destroyed targetpool.remove_node(node) # raises an exception, removes the node nevertheless. Expected behavior: remove the node, return true Fix #2: targetpool.add(node) targetpool.add(node) # targetpool.nodes contains 2 copies of node # actual targetpool resource on the GCE side doesn't contain 2 copies Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side Fix/Improvement #3: Allow specifying nodes by fully-qualified node uri in add_node and remove_node. if tp.nodes: tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist exoected behavior: should be able to remove any node from the list GCE allows adding non-existent nodes to the targetpool and doesn't automatically remove nodes from the pool if you delete them. libcloud should support doing the same. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Kami
pushed a commit
to Kami/libcloud
that referenced
this pull request
Apr 4, 2015
…ompute_driver_rebased Support for Virtual Machine Images and handling of Temp Redirects
asfgit
pushed a commit
that referenced
this pull request
Dec 21, 2015
Fix syntax error for DimensionDataStatus object
asfgit
pushed a commit
that referenced
this pull request
Jul 18, 2019
…ments Oneandone compute driver firewall improvements.
Eis-D-Z
referenced
this pull request
in Eis-D-Z/libcloud
Oct 14, 2020
…_driver_rebased Support for Virtual Machine Images and handling of Temp Redirects
asfgit
pushed a commit
that referenced
this pull request
Nov 5, 2020
asfgit
pushed a commit
that referenced
this pull request
Dec 6, 2020
corrected some errors of typo and update list_image
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dummy Driver list_locations() method returns 3 dummy locations. They all have the same id=1, which is not good(tm)