Add some extra fields in the OpenStack Network Object: #2015 #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micafer
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #2016 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 353 353
Lines 81310 81327 +17
Branches 8565 8568 +3
=======================================
+ Hits 67697 67714 +17
Misses 10823 10823
Partials 2790 2790
|
Kami
reviewed
Jun 16, 2024
| @@ -3160,6 +3160,12 @@ def _to_network(self, obj): | |||
| extra["router:external"] = obj.get("router:external") | |||
| if obj.get("subnets", None): | |||
| extra["subnets"] = obj.get("subnets") | |||
| if obj.get("tags", None): | |||
There was a problem hiding this comment.
Per codecov comment (#2016 (comment)) could you please add additional test cases so all the new code paths are covered?
This includes tests for all those fields being present and not being present (so both the explicit "if" and implicit "else" code branches are covered).
Thanks.
Kami
approved these changes
Jun 17, 2024
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add is_default and tags extra fields in the OpenStack Network Object
Description
Add is_default, description and tags extra fields in the OpenStack Network Object: #2015
Status
Replace this: describe the PR status. Examples:
Checklist (tick everything that applies)