Skip to content

[RFC] Validate SSH key format and size in the SSHKeyDeployment class#170

Closed
Kami wants to merge 1 commit intoapache:trunkfrom
Kami:ssh_key_deployment_improvements
Closed

[RFC] Validate SSH key format and size in the SSHKeyDeployment class#170
Kami wants to merge 1 commit intoapache:trunkfrom
Kami:ssh_key_deployment_improvements

Conversation

@Kami
Copy link
Member

@Kami Kami commented Oct 28, 2013

No description provided.

… and user

uses an RSA key which is <= 1024 bits in size.
@Kami
Copy link
Member Author

Kami commented Oct 28, 2013

This is slightly off topic, but one thing I would also eventually like to do is refactor the libcloud.utils.pubkey module.

I would add a new PublicKey class which would handle all the public key related methods which are currently exported by pubkey module

Advantages of this approach are:

  • No need to copy and paste "if pycrypto available" stuff
  • This class would know how to deal with different key types (rsa, ecdsa, dsa)

Anyway, that's more of a low priority refactoring.

@asfgit asfgit closed this in 0e7454d Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants