Implement floating ips digitalocean #1177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a new unassociated floating IP in a region
delete a floating IP by passing the object into conn.ex_delete_floating_ip or by running .delete on the floating IP object
Throws ValueError if the IP can not be found. Inspired by ex_get_floating_ip from openstack.py, but that one does `ip_obj, = [x for x in floating_ips if x.ip_address == ip]` which will cause an ugly unpacking error if the IP can not be found: `ValueError: need more than 0 values to unpack`
Codecov Report
@@ Coverage Diff @@
## trunk #1177 +/- ##
========================================
Coverage ? 86.18%
========================================
Files ? 348
Lines ? 67207
Branches ? 5958
========================================
Hits ? 57925
Misses ? 6851
Partials ? 2431
Continue to review full report at Codecov.
|
pquentin
approved these changes
Mar 7, 2018
|
Thanks! Merged in trunk. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ex_create_floating_ip, ex_delete_floating_ip, ex_list_floating_ips and ex_get_floating_ip for the DigitalOcean compute driver
See https://developers.digitalocean.com/documentation/v2/#floating-ips