-
Notifications
You must be signed in to change notification settings - Fork 927
Description
Proposal -
This is a follow-up to @rvolykh's proposal in #1403 -
AWS S3 has the support of Presigned Object URL and Azure Blob Storage has the support of Shared access signature. [...]
My proposal is to extend get_object_cdn_url with additional parameter (mode=["read", "write"]) and implement support for AWS S3 and Azure Blob Storage.
The "read" version of this functionality was implemented AWS S3 in #1453 and for Azure Blobs in #1408 via the StorageDriver.get_object_cdn_url
method.
Here I'm proposing the "write" version - a method that generates a pre-authorized, time-limited URL that allows upload of a given object. I think the implementation would be trivial - just change
I'd be happy to contribute a PR for this. But I'm not sure where the new function would go, though. Would it make sense to add a new abstract method to StorageDriver
, e.g., StorageDriver.get_presigned_upload_url(container: str, object_name: str) -> str
?