Skip to content

Commit

Permalink
Make classes inheriting from Type hashable
Browse files Browse the repository at this point in the history
  • Loading branch information
ricardobranco777 committed Aug 23, 2023
1 parent abba8c1 commit e3d0720
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion libcloud/common/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def __repr__(self):
return self.value

def __hash__(self):
return id(self)
return hash(self.value)


class LibcloudError(Exception):
Expand Down
31 changes: 31 additions & 0 deletions libcloud/test/common/test_types.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import unittest

from libcloud.common.types import Type
from libcloud.compute.types import NodeState


class TypeTest(unittest.TestCase):
def test_Type(self):
class TestType(Type):
TESTING = "testing"
self.assertEqual(hash(TestType.TESTING), hash("testing"))
self.assertIn(TestType.TESTING, {"testing"})

def test_NodeState(self):
self.assertEqual(hash(NodeState.RUNNING), hash("running"))
self.assertIn(NodeState.RUNNING, {"running"})

0 comments on commit e3d0720

Please sign in to comment.