Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Bump pnpm to v9 and nodejs to v20 LTS #6712

Closed
wants to merge 2 commits into from
Closed

[UI] Bump pnpm to v9 and nodejs to v20 LTS #6712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9ea922
bump pnpm to v9
bowenliang123 Sep 26, 2024
ca6e425
nit
bowenliang123 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,21 @@ jobs:
SPOTLESS_BLACK_VERSION=$(build/mvn help:evaluate -Dexpression=spotless.python.black.version -q -DforceStdout)
pip install black==$SPOTLESS_BLACK_VERSION
build/mvn spotless:check ${{ matrix.profiles }} -Pspotless-python
- name: Get NodeJS and PNPM version
run: |
NODEJS_VERSION=$(build/mvn help:evaluate -Dexpression=node.version -q -DforceStdout)
PNPM_VERSION=$(build/mvn help:evaluate -Dexpression=pnpm.version -q -DforceStdout)
echo "NODEJS_VERSION=${NODEJS_VERSION}" >> "$GITHUB_ENV"
echo "PNPM_VERSION=${PNPM_VERSION}" >> "$GITHUB_ENV"
- name: setup npm
uses: actions/setup-node@v4
with:
node-version: 18
node-version: ${{env.NODEJS_VERSION}}
- name: Web UI Style with node
run: |
cd ./kyuubi-server/web-ui
npm install pnpm@8 -g
pnpm install
npm install pnpm@${PNPM_VERSION} -g
pnpm install --frozen-lockfile
pnpm run lint
echo "---------------------------------------Notice------------------------------------"
echo "If this style check fail, you should follow these commands for a tentative fix"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/web-ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ jobs:
run: |
cd ./kyuubi-server/web-ui
npm install pnpm@${PNPM_VERSION} -g
pnpm install
pnpm install --frozen-lockfile
pnpm run coverage
pnpm run build
Loading
Loading