Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6666][AUTHZ]Upgrade Ranger plugin to 2.5.0 #6692

Closed
wants to merge 1 commit into from

Conversation

Madhukar525722
Copy link
Contributor

🔍 Description

Issue References 🔗

This pull request fixes #6666

Describe Your Solution 🔧

Bump ranger version to 2.5.0
Release notes: https://cwiki.apache.org/confluence/display/RANGER/Apache+Ranger+2.5.0+-+Release+Notes

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@yaooqinn
Copy link
Member

Can we make the CI happy? Thank you @Madhukar525722

@bowenliang123 bowenliang123 changed the title [KYUUBI #6666] Upgrade spark ranger plugin to 2.5.0 [KYUUBI #6666][AUTHZ]Upgrade Ranger plugin to 2.5.0 Sep 18, 2024
@Madhukar525722
Copy link
Contributor Author

Sure, I will work. Spark tests are failing with

  • check ranger policy file *** FAILED ***
    Line 24 is not expected. The file (/home/runner/work/kyuubi/kyuubi/extensions/spark/kyuubi-spark-authz/src/test/resources/sparkSql_hive_jenkins.json) is out of date. Please regenerate it by running dev/gen/gen_ranger_policy_json.sh. Expected " "[policyItems" : [ {]", but got " "[conditions" : [ ],]" (PolicyJsonFileGenerator.scala:79)

@Madhukar525722 Madhukar525722 force-pushed the ranger_upgrade branch 3 times, most recently from fcc57f1 to b578c75 Compare September 19, 2024 14:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (7198c72) to head (88e1e12).
Report is 11 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6692   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42237   42279   +42     
  Branches     5755    5765   +10     
======================================
- Misses      42237   42279   +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Madhukar525722
Copy link
Contributor Author

Madhukar525722 commented Sep 20, 2024

HI @yaooqinn , CI is smiling. Please review
cc @bowenliang123
After running the policy generator and updating the json. The test was failing due to order mismatch. Thats why I have used serialisation.

@pan3793 pan3793 added this to the v1.10.0 milestone Sep 23, 2024
@pan3793 pan3793 closed this in ebe7e92 Sep 23, 2024
@pan3793
Copy link
Member

pan3793 commented Sep 23, 2024

Thanks, merged to master

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Update Spark Ranger plugin to 2.5.0
5 participants