[KYUUBI #6661] Improve perf for column-based TRowSet generation

[hh-cn]

🔍 Description

Issue References 🔗

This pull request fixes #6661

Describe Your Solution 🔧

TColumnGenerator.getColumnToList should not access to non-IndexedSeq with Seq.apply(i), which will cause performance reduce, convert it to foreach loop will be good. see https://issues.apache.org/jira/browse/SPARK-47085 for more details.

Types of changes 🔖

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

---

Checklist 📝

• This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

[pan3793]

Do you have any statistics to measure the performance improvements? And have you compared the patched version with Spark Thrift Server?

[pan3793]

I see the Spark ticket you attached on the issue, and understand your change now.

The code change LGTM, please fill in the PR description seriously, it's very important for future explorers to understand each patch.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (9533c5a) to head (4597e88).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...apache/kyuubi/engine/result/TColumnGenerator.scala	0.00%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #6662   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         683     683           
  Lines       42205   42204    -1     
  Branches     5756    5755    -1     
======================================
+ Misses      42205   42204    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bowenliang123]

BTW, any benchmark results on the same conditions for comparing looping approaches to support the supposed changes?

[hh-cn]

No benchmark yet

[hh-cn]

@pan3793 the description has been updated, my apologies to miss that. Can this be merged and close it now?

[bowenliang123]

Thanks, merged to master (1.10.0) and branch-1.9 (1.9.3).