-
Notifications
You must be signed in to change notification settings - Fork 944
Upgrade Scala version from 2.13.8 to 2.13.14 #6603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
can we use Scala 2.13.14 to align with Spark 4.0.0-preview1? |
BTW, please rebase your code on latest master branch, there were some issues on CI in my previous commits |
pom.xml
Outdated
@@ -1930,7 +1930,8 @@ | |||
<id>scala-2.13</id> | |||
<properties> | |||
<scala.binary.version>2.13</scala.binary.version> | |||
<scala.version>2.13.8</scala.version> | |||
<!-- Scala version above 2.13.11 support Java 21. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep our dependencies up to date is a regular work, we don't need this comment
the failure should be fixed by upgrade |
yes, I will upgrade |
LGTM if CI pass, thanks for your contribution |
the failure is not a real issue, let's follow apache/spark#46288 to add ignore classes |
Seems |
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
Show resolved
Hide resolved
@@ -241,7 +241,7 @@ | |||
<maven.plugin.jacoco.version>0.8.11</maven.plugin.jacoco.version> | |||
<maven.plugin.scalastyle.version>1.0.0</maven.plugin.scalastyle.version> | |||
<maven.plugin.shade.version>3.5.2</maven.plugin.shade.version> | |||
<maven.plugin.silencer.version>1.7.13</maven.plugin.silencer.version> | |||
<maven.plugin.silencer.version>1.7.17</maven.plugin.silencer.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we have to update the silencer version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each version of silencer has a strictly supported Scala version list, it's common to update with Scala version together
https://mvnrepository.com/artifact/com.github.ghik/silencer-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. SGTM. Thanks for the explanation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6603 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 680 680
Lines 42045 42046 +1
Branches 5739 5739
======================================
- Misses 42045 42046 +1 ☔ View full report in Codecov by Sentry. |
I checked the failure message from
the root cause is that it launches a local cluster using SPARK_HOME, thus using a different Scala library with SPARK_HOME may cause serialization issues as JavaSerializer is not used here. |
Thanks, merged to master |
🔍 Description
Issue References 🔗
To support Java 21, the Scala version needs to be upgraded to 2.13.11 or above.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.