Skip to content

Upgrade Scala version from 2.13.8 to 2.13.14 #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

dupen01
Copy link
Contributor

@dupen01 dupen01 commented Aug 9, 2024

🔍 Description

Issue References 🔗

To support Java 21, the Scala version needs to be upgraded to 2.13.11 or above.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@pan3793
Copy link
Member

pan3793 commented Aug 9, 2024

can we use Scala 2.13.14 to align with Spark 4.0.0-preview1?

@pan3793
Copy link
Member

pan3793 commented Aug 9, 2024

BTW, please rebase your code on latest master branch, there were some issues on CI in my previous commits

pom.xml Outdated
@@ -1930,7 +1930,8 @@
<id>scala-2.13</id>
<properties>
<scala.binary.version>2.13</scala.binary.version>
<scala.version>2.13.8</scala.version>
<!-- Scala version above 2.13.11 support Java 21. -->
Copy link
Member

@pan3793 pan3793 Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep our dependencies up to date is a regular work, we don't need this comment

@dupen01 dupen01 changed the title Upgrade Scala version from 2.13.8 to 2.13.11 Upgrade Scala version from 2.13.8 to 2.13.14 Aug 9, 2024
@pan3793
Copy link
Member

pan3793 commented Aug 9, 2024

the failure should be fixed by upgrade maven.plugin.silencer.version from 1.7.13 to 1.7.17

@dupen01
Copy link
Contributor Author

dupen01 commented Aug 9, 2024

the failure should be fixed by upgrade maven.plugin.silencer.version from 1.7.13 to 1.7.17

yes, I will upgrade maven.plugin.silencer.version to 1.7.17

@pan3793
Copy link
Member

pan3793 commented Aug 9, 2024

LGTM if CI pass, thanks for your contribution

@pan3793
Copy link
Member

pan3793 commented Aug 9, 2024

the failure is not a real issue, let's follow apache/spark#46288 to add ignore classes

@pan3793 pan3793 added this to the v1.10.0 milestone Aug 9, 2024
@pan3793
Copy link
Member

pan3793 commented Aug 9, 2024

Seems FinalStageResourceManagerSuite gets stuck after upgrading Scala 2.13, cc @zhouyifan279 do you have time to take a look? thanks in advance

@@ -241,7 +241,7 @@
<maven.plugin.jacoco.version>0.8.11</maven.plugin.jacoco.version>
<maven.plugin.scalastyle.version>1.0.0</maven.plugin.scalastyle.version>
<maven.plugin.shade.version>3.5.2</maven.plugin.shade.version>
<maven.plugin.silencer.version>1.7.13</maven.plugin.silencer.version>
<maven.plugin.silencer.version>1.7.17</maven.plugin.silencer.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have to update the silencer version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each version of silencer has a strictly supported Scala version list, it's common to update with Scala version together
https://mvnrepository.com/artifact/com.github.ghik/silencer-plugin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. SGTM. Thanks for the explanation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (df8448c) to head (541f860).
Report is 2 commits behind head on master.

Files Patch % Lines
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6603   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         680     680           
  Lines       42045   42046    +1     
  Branches     5739    5739           
======================================
- Misses      42045   42046    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the kind:documentation Documentation is a feature! label Aug 22, 2024
@github-actions github-actions bot added kind:infra license, community building, project builds, asf infra related, etc. and removed module:common kind:deploy labels Aug 22, 2024
@pan3793
Copy link
Member

pan3793 commented Aug 22, 2024

I checked the failure message from FinalStageResourceManagerSuite

16:21:05.237 ERROR org.apache.spark.network.server.TransportRequestHandler: Error while invoking RpcHandler#receive() on RPC id 9220236832923458123
java.io.InvalidClassException: scala.concurrent.duration.FiniteDuration; local class incompatible: stream classdesc serialVersionUID = -4594686286536372853, local class serialVersionUID = -6513803676778706429
        at java.base/java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:597)
        ...
        at org.apache.spark.serializer.JavaDeserializationStream.readObject(JavaSerializer.scala:87)
        at org.apache.spark.serializer.JavaSerializerInstance.deserialize(JavaSerializer.scala:123)
        at org.apache.spark.rpc.netty.NettyRpcEnv.$anonfun$deserialize$2(NettyRpcEnv.scala:299)
        at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
        at org.apache.spark.rpc.netty.NettyRpcEnv.deserialize(NettyRpcEnv.scala:352)

the root cause is that it launches a local cluster using SPARK_HOME, thus using a different Scala library with SPARK_HOME may cause serialization issues as JavaSerializer is not used here.

@pan3793
Copy link
Member

pan3793 commented Aug 23, 2024

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:build kind:infra license, community building, project builds, asf infra related, etc. module:server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants