Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6449] Fix Gluten CI ClassNotFoundException: io.glutenproject.GlutenPlugin #6449

Closed
wants to merge 21 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/gluten.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ name: Gluten CI
on:
schedule:
- cron: 0 4 * * *
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this before merge

branches:
- master
workflow_dispatch:

env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded,gen-policy -Dmaven.plugin.download.cache.path=/tmp/engine-archives
Expand Down Expand Up @@ -61,9 +65,9 @@ jobs:
- name: Build gluten project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try remove libunwind-dev at line46

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Let me try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulysses-you It failed at StepInstall dependencies.

+ sudo --preserve-env apt install -y libc-ares-dev libcurl4-openssl-dev libssl-dev libicu-dev libdouble-conversion-dev libgoogle-glog-dev libbz2-dev libgflags-dev libevent-dev liblz4-dev libzstd-dev libre2-dev libsnappy-dev libsodium-dev libthrift-dev liblzo2-dev libelf-dev libdwarf-dev bison flex libfl-dev tzdata

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Reading package lists...
Building dependency tree...
Reading state information...
bison is already the newest version (2:3.8.2+dfsg-1build1).
flex is already the newest version (2.6.4-8build2).
libbz2-dev is already the newest version (1.0.8-5build1).
libbz2-dev set to manually installed.
libicu-dev is already the newest version (70.1-2).
libicu-dev set to manually installed.
liblz4-dev is already the newest version (1.9.3-2build2).
libre2-dev is already the newest version (20220201+dfsg-1).
libzstd-dev is already the newest version (1.4.8+dfsg-3build1).
libzstd-dev set to manually installed.
libthrift-dev is already the newest version (0.16.0-2).
libcurl4-openssl-dev is already the newest version (7.81.0-1ubuntu1.16).
libssl-dev is already the newest version (3.0.2-0ubuntu1.15).
tzdata is already the newest version (2024a-0ubuntu0.22.04).
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libgoogle-glog-dev : Depends: libunwind-dev or
                               libunwind7-dev but it is not installable
E: Unable to correct problems, you have held broken packages.
``

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try libunwind7-dev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libunwind7-dev does not work either

run: |
if [[ "${{ steps.gluten-cache.outputs.cache-hit }}" != 'true' ]]; then
git clone https://github.com/oap-project/gluten.git
git clone https://github.com/apache/incubator-gluten.git gluten
cd gluten
./dev/buildbundle-veloxbe.sh
./dev/package.sh
fi
- uses: actions/cache@v3
if: steps.gluten-cache.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -115,6 +119,9 @@ jobs:
- name: Run Gluten Integration TPC-H/DS Test
run: |
TEST_MODULES="integration-tests/kyuubi-gluten-it"
export LD_LIBRARY_PATH=$(pwd)/gluten/package/target/thirdparty-lib
# Enable core dumping
ulimit -c unlimited
./build/mvn ${MVN_OPT} -Pgluten-it -Pspark-${{ matrix.spark }} -pl ${TEST_MODULES} -am clean install -DskipTests
./build/mvn ${MVN_OPT} -Pgluten-it -Pspark-${{ matrix.spark }} -pl ${TEST_MODULES} test
- name: Upload test logs
Expand All @@ -124,3 +131,10 @@ jobs:
name: unit-tests-log-spark-${{ matrix.spark }}-gluten
path: |
**/target/unit-tests.log
- name: Upload JVM error logs
if: failure()
uses: actions/upload-artifact@v3
with:
name: jvm-error-log-spark-${{ matrix.spark }}-gluten
path: |
integration-tests/kyuubi-gluten-it/*.log
2 changes: 1 addition & 1 deletion docs/deployment/spark/gluten.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Add gluten jar: `copy /path/to/gluten/package/target/gluten-velox-bundle-spark3.
Add the following minimal configuration into `spark-defaults.conf`:

```properties
spark.plugins=io.glutenproject.GlutenPlugin
spark.plugins=org.apache.gluten.GlutenPlugin
spark.memory.offHeap.size=20g
spark.memory.offHeap.enabled=true
spark.shuffle.manager=org.apache.spark.shuffle.sort.ColumnarShuffleManager
Expand Down
21 changes: 18 additions & 3 deletions integration-tests/kyuubi-gluten-it/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,16 @@

<properties>
<gluten.version>1.2.0-SNAPSHOT</gluten.version>
<gluten.artifact.name>gluten-velox-bundle-spark${spark.binary.version}_${scala.binary.version}-ubuntu_22.04</gluten.artifact.name>
<gluten.artifact.name>gluten-velox-bundle-spark${spark.binary.version}_${scala.binary.version}</gluten.artifact.name>
</properties>

<dependencies>
<dependency>
<groupId>io.glutenproject</groupId>
<groupId>org.apache.gluten</groupId>
<artifactId>${gluten.artifact.name}</artifactId>
<version>${gluten.version}</version>
<scope>system</scope>
<systemPath>${project.basedir}/../../gluten/package/target/${gluten.artifact.name}_x86_64-${gluten.version}.jar</systemPath>
<systemPath>${project.basedir}/../../gluten/package/target/${gluten.artifact.name}-${os.detected.release}_${os.detected.release.version}_${os.detected.arch}-${gluten.version}.jar</systemPath>
</dependency>

<dependency>
Expand All @@ -57,6 +57,14 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.kyuubi</groupId>
<artifactId>kyuubi-util-scala_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.kyuubi</groupId>
<artifactId>kyuubi-spark-connector-common_${scala.binary.version}</artifactId>
Expand Down Expand Up @@ -88,6 +96,13 @@
<artifactId>spark-hive_${scala.binary.version}</artifactId>
<scope>test</scope>
</dependency>

<!-- javax.servlet-api is required by Spark 3.x -->
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ import org.apache.kyuubi.tags.GlutenTest
@Slow
@GlutenTest
class GlutenTPCHQuerySuite extends KyuubiFunSuite with GlutenSuiteMixin {
// TODO: Fix the inconsistency in q9 results.
val queries: Set[String] = (1 to 22).map(i => s"q$i").toSet - "q9"
// TODO: Fix the inconsistency in q3,q9 results.
val queries: Set[String] = (1 to 22)
.map(i => s"q$i").toSet - "q3" - "q9"

lazy val sparkConf: SparkConf = {
val glutenConf = new SparkConf().setMaster("local[*]")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ trait GlutenSuiteMixin {
}

protected def extraConfigs: Map[String, String] = Map(
"spark.plugins" -> "io.glutenproject.GlutenPlugin",
"spark.plugins" -> "org.apache.gluten.GlutenPlugin",
"spark.memory.offHeap.size" -> "4g",
"spark.memory.offHeap.enabled" -> "true",
"spark.shuffle.manager" -> "org.apache.spark.shuffle.sort.ColumnarShuffleManager",
Expand Down
10 changes: 10 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@
<maven.plugin.enforcer.mojo.rules.version>1.6.1</maven.plugin.enforcer.mojo.rules.version>
<maven.plugin.flatten.version>1.6.0</maven.plugin.flatten.version>
<maven.plugin.frontend.version>1.12.1</maven.plugin.frontend.version>
<maven.plugin.os.version>1.7.1</maven.plugin.os.version>
<maven.plugin.scala.version>4.8.0</maven.plugin.scala.version>
<maven.plugin.scalatest.version>2.2.0</maven.plugin.scalatest.version>
<maven.plugin.scalatest.exclude.tags>org.scalatest.tags.Slow</maven.plugin.scalatest.exclude.tags>
Expand Down Expand Up @@ -1257,6 +1258,7 @@
</pluginRepositories>

<build>

<pluginManagement>
<plugins>
<plugin>
Expand Down Expand Up @@ -1836,6 +1838,14 @@
</executions>
</plugin>
</plugins>
<extensions>
<!-- provides os.detected.classifier (i.e. linux-x86_64, osx-x86_64) property -->
<extension>
<groupId>kr.motd.maven</groupId>
<artifactId>os-maven-plugin</artifactId>
<version>${maven.plugin.os.version}</version>
</extension>
</extensions>
</build>

<profiles>
Expand Down
Loading