[KYUUBI #6032] Expose KyuubiOperation exec time metrics #6038
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6038 +/- ##
============================================
- Coverage 61.18% 61.07% -0.11%
Complexity 23 23
============================================
Files 623 623
Lines 37145 37142 -3
Branches 5033 5033
============================================
- Hits 22726 22684 -42
- Misses 11979 12001 +22
- Partials 2440 2457 +17 ☔ View full report in Codecov by Sentry. |
| ms.markMeter(MetricRegistry.name(OPERATION_STATE, opType, state.toString.toLowerCase), -1) | ||
| } else { | ||
| val execTime = System.currentTimeMillis() - startTime |
There was a problem hiding this comment.
+1 for createTime, it makes sense for customer.
There was a problem hiding this comment.
Using createTime would duplicate the metric with the kyuubi.backend_service.xxxx.
There was a problem hiding this comment.
Using
createTimewould duplicate the metric with thekyuubi.backend_service.xxxx.
It looks like this, let's keep startTime
There was a problem hiding this comment.
Then this will introduce another discussion. Since there are kyuubi.backend_service.xxx metircs, do we still need to add exec_time metric for each operation?
cxzl25
changed the title
🔍 Description
Issue References 🔗
This pull request fixes #6032
Describe Your Solution 🔧
KyuubiOperation (LaunchEngine, ExecutedCommandExec) supports exec_time metrics
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.