Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #5863] BatchJobSubmission close repeatedly #5864

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ASiegeLion
Copy link
Contributor

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklists

📝 Author Self Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

  • Pull request title is okay.
  • No license issues.
  • Milestone correctly set?
  • Test coverage is ok
  • Assignees are selected.
  • Minimum number of approvals
  • No changes are requested

Be nice. Be informative.

@pan3793 pan3793 changed the title [KYUUBI #5863]BatchJobSubmission repeatedly closed [KYUUBI #5863] BatchJobSubmission close repeatedly Dec 16, 2023
@@ -207,7 +207,6 @@ class KyuubiBatchSession(

override def close(): Unit = {
super.close()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super.close() only closes running operations, so it does not include batchJobSubmissionOp before batchJobSubmissionOp runs.

@wForget
Copy link
Member

wForget commented Jan 25, 2024

According to the description of your issue, we may be able to modify BatchJobSubmission#close like this:

  override def close(): Unit = withLockRequired {
    if (!isClosedOrCanceled) {
      withClosingOperationLog {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants