Handle the session exception for all kyuubi operations during running #5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
save Revert "save" This reverts commit c3f8fca. session
turboFei
force-pushed
the
handle_session_exception_rest
branch
from
58d02e5
to
5d9d4dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5725 +/- ##
============================================
- Coverage 61.37% 61.28% -0.09%
Complexity 23 23
============================================
Files 607 607
Lines 35820 35836 +16
Branches 4914 4917 +3
============================================
- Hits 21983 21962 -21
- Misses 11456 11482 +26
- Partials 2381 2392 +11 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Nov 19, 2023
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala
Outdated
Show resolved
Hide resolved
|
cc @pan3793 |
pan3793
pushed a commit
that referenced
this pull request
Nov 20, 2023
… during running # 🔍 Description Now only the `LaunchEngine` and `BatchJobSubmission` handle the kyuubi session exception. We shall handle the session exception for all kyuubi operations, so that the user can get the correct KyuubiSessionEvent with RESTful API. ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [ ] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [ ] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes #5725 from turboFei/handle_session_exception_rest. Closes #5725 dd514f3 [fwang12] remove 1614951 [fwang12] handle cee9171 [fwang12] Revert "handle session exception for all kyuubi operations" 4a0c192 [fwang12] Revert "comment" 7ce89f8 [fwang12] comment 5d9d4dc [fwang12] handle session exception for all kyuubi operations Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 39f39a1) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Now only the
LaunchEngineandBatchJobSubmissionhandle the kyuubi session exception.We shall handle the session exception for all kyuubi operations, so that the user can get the correct KyuubiSessionEvent with RESTful API.
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.