Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] kyuubi-spark-lineage has no transitive deps #4727

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Apr 18, 2023

Why are the changes needed?

Update outdated docs

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

Codecov Report

Merging #4727 (b6843b2) into master (f6331a2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4727   +/-   ##
=========================================
  Coverage     58.00%   58.01%           
  Complexity       13       13           
=========================================
  Files           581      581           
  Lines         32297    32297           
  Branches       4313     4313           
=========================================
+ Hits          18734    18736    +2     
- Misses        11759    11760    +1     
+ Partials       1804     1801    -3     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iodone
Copy link
Contributor

iodone commented Apr 19, 2023

LGTM

@iodone iodone closed this in 609018a Apr 19, 2023
@pan3793 pan3793 self-assigned this Apr 19, 2023
@pan3793 pan3793 added this to the v1.7.1 milestone Apr 19, 2023
pan3793 added a commit that referenced this pull request Apr 19, 2023
### _Why are the changes needed?_

Update outdated docs

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4727 from pan3793/lineage-doc.

Closes #4727

b6843b2 [Cheng Pan] [DOC] kyuubi-spark-lineage has no transitive deps

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: odone <odone.zhang@gmail.com>
@pan3793
Copy link
Member Author

pan3793 commented Apr 19, 2023

Also cherry-picked to 1.7

@pan3793 pan3793 deleted the lineage-doc branch October 7, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants