Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTHZ] Check Authz plugin's spec json files in UT #4717

Conversation

packyan
Copy link
Contributor

@packyan packyan commented Apr 16, 2023

Why are the changes needed?

to close #4715

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@packyan packyan changed the title [Improvement] [AUTHZ] Spec json files should be auto generated in each build [KYUUBI 4715] [Improvement] [AUTHZ] Spec json files should be auto generated in each build Apr 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Merging #4717 (88e70da) into master (2ed0990) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4717      +/-   ##
============================================
- Coverage     58.06%   58.02%   -0.04%     
  Complexity       13       13              
============================================
  Files           581      581              
  Lines         32297    32297              
  Branches       4313     4313              
============================================
- Hits          18753    18741      -12     
- Misses        11746    11755       +9     
- Partials       1798     1801       +3     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bowenliang123
Copy link
Contributor

Hi, the spec json file should not be regenerated in each build, by design. But yes, it should be checked during ci builds.

@packyan packyan changed the title [KYUUBI 4715] [Improvement] [AUTHZ] Spec json files should be auto generated in each build [KYUUBI 4715] [Improvement] [AUTHZ] Check Spec json files in UT Apr 17, 2023
@packyan
Copy link
Contributor Author

packyan commented Apr 17, 2023

Hi, the spec json file should not be regenerated in each build, by design. But yes, it should be checked during ci builds.

Yes, I will add a UT to check generated golden files.

@bowenliang123
Copy link
Contributor

Alright, I mean change it from executing the main method to running it in test suites, for both validation in testing and regeneration, just to be clear.

@packyan
Copy link
Contributor Author

packyan commented Apr 17, 2023

Alright, I mean change it from executing the main method to running it in test suites, for both validation in testing and regeneration, just to be clear.

understood

@bowenliang123 bowenliang123 changed the title [KYUUBI 4715] [Improvement] [AUTHZ] Check Spec json files in UT [KYUUBI 4715] [Improvement] Check Spec json files in UT Apr 17, 2023
@bowenliang123 bowenliang123 changed the title [KYUUBI 4715] [Improvement] Check Spec json files in UT [KYUUBI 4715] Check Authz plugin's spec json files in UT Apr 17, 2023
@bowenliang123 bowenliang123 added this to the v1.8.0 milestone Apr 17, 2023
@bowenliang123
Copy link
Contributor

Would you like to remove redundant changes in generator and policy json file of #4716 which is already merged ? @packyan

@bowenliang123 bowenliang123 changed the title [KYUUBI 4715] Check Authz plugin's spec json files in UT [AUTHZ] Check Authz plugin's spec json files in UT Apr 19, 2023
@packyan
Copy link
Contributor Author

packyan commented Apr 19, 2023

Would you like to remove redundant changes in generator and policy json file of #4716 which is already merged ? @packyan

Done, wait for CI finished.

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Minor comment.

@bowenliang123
Copy link
Contributor

Thanks for your continuous contribution. Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] [AUTHZ] Spec json files should be auto generated, rather than edit manually
3 participants