-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTHZ] Check Authz plugin's spec json files in UT #4717
[AUTHZ] Check Authz plugin's spec json files in UT #4717
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4717 +/- ##
============================================
- Coverage 58.06% 58.02% -0.04%
Complexity 13 13
============================================
Files 581 581
Lines 32297 32297
Branches 4313 4313
============================================
- Hits 18753 18741 -12
- Misses 11746 11755 +9
- Partials 1798 1801 +3 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi, the spec json file should not be regenerated in each build, by design. But yes, it should be checked during ci builds. |
Yes, I will add a UT to check generated golden files. |
Alright, I mean change it from executing the main method to running it in test suites, for both validation in testing and regeneration, just to be clear. |
understood |
fac3765
to
a078c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Minor comment.
...rk-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/JsonSpecFileGenerator.scala
Outdated
Show resolved
Hide resolved
Thanks for your continuous contribution. Merged to master. |
Why are the changes needed?
to close #4715
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request