[KYUUBI 4650][Improvement] LogDivertAppender supports reading RollingFileAppender pattern #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4653 +/- ##
============================================
- Coverage 57.64% 57.56% -0.08%
Complexity 13 13
============================================
Files 579 579
Lines 31901 31958 +57
Branches 4263 4271 +8
============================================
+ Hits 18389 18397 +8
- Misses 11755 11793 +38
- Partials 1757 1768 +11
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cxzl25
approved these changes
Apr 4, 2023
yaooqinn
reviewed
Apr 4, 2023
Comment on lines
95
to
96
| (ap.isInstanceOf[ConsoleAppender] || ap.isInstanceOf[RollingFileAppender]) | ||
| && ap.getLayout.isInstanceOf[StringLayout]) |
There was a problem hiding this comment.
Suggested change
| (ap.isInstanceOf[ConsoleAppender] || ap.isInstanceOf[RollingFileAppender]) | |
| && ap.getLayout.isInstanceOf[StringLayout]) | |
| (ap.isInstanceOf[ConsoleAppender] || ap.isInstanceOf[RollingFileAppender]) && | |
| ap.getLayout.isInstanceOf[StringLayout]) |
yaooqinn
approved these changes
Apr 4, 2023
pan3793
pushed a commit
that referenced
this pull request
Apr 4, 2023
…reading RollingFileAppender pattern ### _Why are the changes needed?_ close #4650 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4653 from lsm1/features/kyuubi_4650. Closes #4653 79962aa [senmiaoliu] reformat e4bb732 [senmiaoliu] respect user log pattern Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 473907c) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #4650
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request