[KYUUBI #4522] use:catalog should execute before than use:database
#4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4648 +/- ##
============================================
- Coverage 57.64% 57.60% -0.04%
Complexity 13 13
============================================
Files 579 579
Lines 31901 31956 +55
Branches 4263 4270 +7
============================================
+ Hits 18389 18409 +20
- Misses 11755 11786 +31
- Partials 1757 1761 +4
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
reviewed
Apr 3, 2023
| @@ -57,16 +57,20 @@ class FlinkSessionImpl( | |||
|
|
|||
| override def open(): Unit = { | |||
| executor.openSession(handle.identifier.toString) | |||
| normalizedConf.foreach { | |||
| case ("use:catalog", catalog) => | |||
| normalizedConf.get("use:catalog") match { | |||
There was a problem hiding this comment.
How about
val (useCatalogAndDatabaseConf, otherConf) = normalizedConf.partition { case (k, _) =>
Array("use:catalog", "use:database").contains(k)
}
?
|
Apply the same changes on Trino session too? |
pan3793
reviewed
Apr 3, 2023
| Array("use:catalog", "use:database").contains(k) | ||
| } | ||
|
|
||
| useCatalogAndDatabaseConf.get("use:catalog") match { |
There was a problem hiding this comment.
Suggested change
| useCatalogAndDatabaseConf.get("use:catalog") match { | |
| useCatalogAndDatabaseConf.get("use:catalog").foreach { catalog => | |
| ... |
pan3793
changed the title
use:catalog should execute before than use:database
|
Thanks, merged to master/1.7 |
pan3793
pushed a commit
that referenced
this pull request
Apr 4, 2023
### _Why are the changes needed?_ close #4522 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4648 from lsm1/fix/kyuubi_4522. Closes #4522 e060468 [senmiaoliu] use foreach bd83d66 [senmiaoliu] spilt narmalizedConf 4d8445a [senmiaoliu] avoid sort eda34d4 [senmiaoliu] use catalog first Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit f0796ec) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #4522
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request