Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add rule for labeler to tag module:ui #4632

Closed
wants to merge 2 commits into from
Closed

[CI] Add rule for labeler to tag module:ui #4632

wants to merge 2 commits into from

Conversation

zwangsheng
Copy link
Contributor

@zwangsheng zwangsheng commented Mar 29, 2023

Why are the changes needed?

Current Labeler mis-tags module:server to changes about web-ui.

We should give module:ui tag to ui-related PR.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Mar 29, 2023
@zwangsheng zwangsheng changed the title [CI] Add rule for labeler tag module:UI [CI] Add rule for labeler to tag module:ui Mar 29, 2023
@pan3793 pan3793 added this to the v1.8.0 milestone Mar 30, 2023
@pan3793
Copy link
Member

pan3793 commented Mar 30, 2023

Thanks, merged to master

@pan3793 pan3793 closed this in 3692755 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:infra license, community building, project builds, asf infra related, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants