Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependency management ISSUE_TEMPLATE #4628

Closed
wants to merge 7 commits into from
Closed

Conversation

yaooqinn
Copy link
Member

Why are the changes needed?

Add Dependency management ISSUE_TEMPLATE as behaviors about upgrading artifacts are frequent

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Mar 28, 2023
- type: textarea
id: release_notes
attributes:
label: Release Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part may not limit to release note, how about "Notable Changes"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound reasonable, addressed

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #4628 (595a2d3) into master (6fd3353) will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4628      +/-   ##
============================================
+ Coverage     53.33%   53.51%   +0.18%     
  Complexity       13       13              
============================================
  Files           577      579       +2     
  Lines         31591    31781     +190     
  Branches       4249     4253       +4     
============================================
+ Hits          16849    17009     +160     
- Misses        13158    13181      +23     
- Partials       1584     1591       +7     

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 closed this in 27d05b6 Mar 29, 2023
@pan3793 pan3793 added this to the v1.8.0 milestone Mar 29, 2023
@pan3793
Copy link
Member

pan3793 commented Mar 29, 2023

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:infra license, community building, project builds, asf infra related, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants