[K8S][HELM] Set IfNotPresent pullPolicy by default #4605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Mar 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #4605 +/- ##
============================================
- Coverage 53.32% 53.31% -0.02%
Complexity 13 13
============================================
Files 577 577
Lines 31584 31584
Branches 4248 4248
============================================
- Hits 16843 16839 -4
- Misses 13154 13156 +2
- Partials 1587 1589 +2 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
pushed a commit
that referenced
this pull request
Mar 26, 2023
### _Why are the changes needed?_ The change is needed to avoid pulling immutable image `apache/kyuubi:1.7.0` from image registry each time pod created. Current `pullPolicy: Always` was important when mutable image `apache/kyuubi:master-snapshot` was used. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4605 from dnskr/chart_pullPolicy. Closes #4605 0f323ab [dnskr] [K8S][HELM] Set IfNotPresent pullPolicy by default Authored-by: dnskr <dnskrv88@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 5289d1c) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.7 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The change is needed to avoid pulling immutable image
apache/kyuubi:1.7.0from image registry each time pod created.Current
pullPolicy: Alwayswas important when mutable imageapache/kyuubi:master-snapshotwas used.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request