-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHAT] Make ChatGPT model ID configurable #4558
Conversation
According to OpenAI's API reference(https://platform.openai.com/docs/api-reference/completions/create), many detailed settings of chat completion request, other than model id, like |
I would suggest just exposing the most frequently usage small set of the whole parameters. |
Please add this PR into the Umbrella task list |
Agree. And let's expose parameters on specific purpose. |
Added. Thx for reminder. |
Codecov Report
@@ Coverage Diff @@
## master #4558 +/- ##
============================================
- Coverage 53.27% 53.25% -0.02%
Complexity 13 13
============================================
Files 573 573
Lines 31493 31498 +5
Branches 4237 4237
============================================
- Hits 16777 16775 -2
- Misses 13135 13140 +5
- Partials 1581 1583 +2
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks, merged to master. |
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request