-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #4376] Support to config the kyuubi service administrator with kyuubi conf #4405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or with kyuubi conf
github-actions
bot
added
kind:documentation
Documentation is a feature!
module:common
module:server
labels
Feb 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #4405 +/- ##
=========================================
Coverage 53.81% 53.81%
Complexity 13 13
=========================================
Files 564 564
Lines 30929 30964 +35
Branches 4163 4170 +7
=========================================
+ Hits 16643 16663 +20
- Misses 12735 12739 +4
- Partials 1551 1562 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
turboFei
reviewed
Feb 25, 2023
turboFei
reviewed
Feb 25, 2023
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala
Outdated
Show resolved
Hide resolved
turboFei
reviewed
Feb 25, 2023
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
turboFei
changed the title
[KYUUBI #4376] Support to config the kyuubi service administrator wit…
[KYUUBI #4376] Support to config the kyuubi service administrator with kyuubi conf
Feb 25, 2023
turboFei
approved these changes
Feb 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #4376
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request