Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #4376] Support to config the kyuubi service administrator with kyuubi conf #4405

Closed
wants to merge 2 commits into from

Conversation

lightning-L
Copy link
Contributor

@lightning-L lightning-L commented Feb 24, 2023

Why are the changes needed?

Close #4376

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #4405 (1a01a75) into master (86dc59c) will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff            @@
##             master    #4405   +/-   ##
=========================================
  Coverage     53.81%   53.81%           
  Complexity       13       13           
=========================================
  Files           564      564           
  Lines         30929    30964   +35     
  Branches       4163     4170    +7     
=========================================
+ Hits          16643    16663   +20     
- Misses        12735    12739    +4     
- Partials       1551     1562   +11     
Impacted Files Coverage Δ
...rg/apache/kyuubi/server/api/v1/AdminResource.scala 95.55% <83.33%> (+0.10%) ⬆️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.47% <100.00%> (-0.06%) ⬇️
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 59.09% <0.00%> (-7.58%) ⬇️
...g/apache/kyuubi/operation/BatchJobSubmission.scala 75.27% <0.00%> (-2.20%) ⬇️
...in/lineage/helper/SparkSQLLineageParseHelper.scala 63.03% <0.00%> (-0.37%) ⬇️
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 42.50% <0.00%> (ø)
...in/java/org/apache/hive/beeline/KyuubiBeeLine.java 0.00% <0.00%> (ø)
...n/java/org/apache/hive/beeline/KyuubiCommands.java 0.00% <0.00%> (ø)
.../org/apache/kyuubi/config/KyuubiReservedKeys.scala 0.00% <0.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lightning-L
Copy link
Contributor Author

@turboFei

@turboFei turboFei changed the title [KYUUBI #4376] Support to config the kyuubi service administrator wit… [KYUUBI #4376] Support to config the kyuubi service administrator with kyuubi conf Feb 25, 2023
Copy link
Member

@turboFei turboFei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turboFei turboFei closed this in 59c1875 Feb 26, 2023
@turboFei
Copy link
Member

thanks, merged to master

@turboFei turboFei added this to the v1.8.0 milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support to config the kyuubi service administrator with kyuubi conf
3 participants