Support batch session limiter and user white list #3957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
github-actions
bot
added
kind:documentation
turboFei
force-pushed
the
batch_session_limiter
branch
2 times, most recently
from
73a0668 to
6aa11ef
Compare
turboFei
changed the title
turboFei
force-pushed
the
batch_session_limiter
branch
from
6aa11ef to
55db79e
Compare
turboFei
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3957 +/- ##
============================================
- Coverage 51.96% 51.94% -0.02%
Complexity 13 13
============================================
Files 522 522
Lines 28870 28916 +46
Branches 3864 3866 +2
============================================
+ Hits 15001 15021 +20
- Misses 12498 12518 +20
- Partials 1371 1377 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wForget
approved these changes
Dec 12, 2022
|
thanks, merged to master |
pan3793
reviewed
Dec 12, 2022
| kyuubi.server.info.provider|ENGINE|The server information provider name, some clients may rely on this information to check the server compatibilities and functionalities. <li>SERVER: Return Kyuubi server information.</li> <li>ENGINE: Return Kyuubi engine information.</li>|string|1.6.1 | ||
| kyuubi.server.limit.connections.per.ipaddress|<undefined>|Maximum kyuubi server connections per ipaddress. Any user exceeding this limit will not be allowed to connect.|int|1.6.0 | ||
| kyuubi.server.limit.connections.per.user|<undefined>|Maximum kyuubi server connections per user. Any user exceeding this limit will not be allowed to connect.|int|1.6.0 | ||
| kyuubi.server.limit.connections.per.user.ipaddress|<undefined>|Maximum kyuubi server connections per user:ipaddress combination. Any user-ipaddress exceeding this limit will not be allowed to connect.|int|1.6.0 | ||
| kyuubi.server.limit.connections.user.white.list||The maximin connections of the user in the white list will not be limited.|seq|1.7.0 |
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Dec 12, 2022
…ted user list config
3 tasks
turboFei
added a commit
that referenced
this pull request
Dec 12, 2022
…er list config ### _Why are the changes needed?_ Followup for #3957 comments ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3963 from turboFei/unlimited_user. Closes #3957 987b71f [fwang12] refactor e0c6ca5 [fwang12] [KYUUBI #3957][FOLLOWUP] Refactor the session connection unlimited user list config Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
turboFei
added a commit
that referenced
this pull request
Feb 23, 2023
…batch.limit to kyuubi.server.limit.batch ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4398 from turboFei/rename_batch_limit. Closes #3957 28228e4 [fwang12] 3957 followup ef1ad6e [fwang12] save Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Feb 23, 2023
…erver.batch.limit to kyuubi.server.limit.batch
turboFei
added a commit
that referenced
this pull request
Feb 23, 2023
…rver.batch.limit to kyuubi.server.limit.batch ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4400 from turboFei/4398_1.7. Closes #3957 66c0064 [fwang12] [KYUUBI #3957][FOLLOWUP] Rename the config prefix from kyuubi.server.batch.limit to kyuubi.server.limit.batch Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
turboFei
added a commit
that referenced
this pull request
Feb 23, 2023
…rver.batch.limit to kyuubi.server.limit.batch ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4400 from turboFei/4398_1.7. Closes #3957 e12bd93 [fwang12] save 66c0064 [fwang12] [KYUUBI #3957][FOLLOWUP] Rename the config prefix from kyuubi.server.batch.limit to kyuubi.server.limit.batch Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Support dedicated limiter for batch session.
Support user white list.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request