Skip to content

Conversation

@ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Nov 22, 2021

Why are the changes needed?

In order to compaible with both Spark-2 and Spark-3, we should respect package ui, since apache/spark#22645, some class cope changed from package ui to spark.

How was this patch tested?

Pass CI

@ulysses-you ulysses-you changed the title [KYUUBI #1429] Move ui package from org.apache.spark to org.apache.spark.ui [KYUUBI #1429][TASK-1] Move ui package from org.apache.spark to org.apache.spark.ui Nov 22, 2021
@ulysses-you ulysses-you linked an issue Nov 22, 2021 that may be closed by this pull request
3 tasks
@ulysses-you
Copy link
Contributor Author

cc @timothy65535

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #1430 (c8bddf9) into master (6bb5af6) will decrease coverage by 0.96%.
The diff coverage is 33.33%.

❗ Current head c8bddf9 differs from pull request most recent head 8b40c60. Consider uploading reports for the commit 8b40c60 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1430      +/-   ##
============================================
- Coverage     58.91%   57.94%   -0.97%     
  Complexity      155      155              
============================================
  Files           232      224       -8     
  Lines         11928    11672     -256     
  Branches       1460     1417      -43     
============================================
- Hits           7027     6763     -264     
- Misses         4309     4370      +61     
+ Partials        592      539      -53     
Impacted Files Coverage Δ
...rc/main/scala/org/apache/spark/ui/EnginePage.scala 80.25% <0.00%> (ø)
.../scala/org/apache/spark/ui/EngineSessionPage.scala 3.12% <ø> (ø)
...src/main/scala/org/apache/spark/ui/EngineTab.scala 72.41% <ø> (ø)
...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala 65.33% <100.00%> (ø)
...ver/mysql/authentication/MySQLNativePassword.scala 9.09% <0.00%> (-68.19%) ⬇️
...ver/mysql/authentication/MySQLAuthentication.scala 3.33% <0.00%> (-52.23%) ⬇️
...e/kyuubi/server/mysql/constant/MySQLDataType.scala 2.60% <0.00%> (-22.61%) ⬇️
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 6.15% <0.00%> (-7.70%) ⬇️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 70.21% <0.00%> (-6.39%) ⬇️
.../apache/kyuubi/server/mysql/MySQLRichByteBuf.scala 44.44% <0.00%> (-6.18%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19d463...8b40c60. Read the comment docs.

@yaooqinn yaooqinn added this to the v1.4.0 milestone Nov 22, 2021
@ulysses-you
Copy link
Contributor Author

thanks, merging to master

@ulysses-you ulysses-you self-assigned this Nov 23, 2021
@ulysses-you ulysses-you deleted the spark-2.4 branch November 23, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Umbrella] Support engine with Spark-2.4

4 participants