-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK][EASY] JDBC Engine supports StarRocks #5404
Comments
Hello @banmoy, |
@pan3793 could you help to evaluate whether this issue can be added to the task list of Code Contribution Program? Thanks |
@banmoy thanks, task was added to the list |
Thanks a lot 😃 |
@banmoy would you like to complete it by yourself, or leave it to other contributors? |
@pan3793 could first leave it to other contributors if they are interested in it |
Thanks for raising this task. We could split the task into several smaller subtasks to accomplish. |
Btw, consider using the official docker image from StarRocks for testing, which could be helpful and easy to maintain. |
@pan3793 Hello, I have strong interests on it and during my daily work, Apache Kyuubi and StarRocks are two most useful tools. I think it can be finished in 14 days! please aisgn it to me~thx |
@phionex0571 Emm... you have been assigned 2 tasks, do you have sufficient free time to take the third and complete them in parallel? |
@banmoy Can I assign this task to you , and you can guide and cooperate with @phionex0571 ? In order to maximize the common knowledge from individuals and professionalism from SR team. |
@pan3793 Yeeep, in the previous year, I'd finished a StarRocks proxy in Apache Kyuubi 1.4, but that was not elegant and that was imitated like Apache Doris Engine implementation in Apache Kyuubi. And it's applied by 3 applications in production environment of my company. I hold strong belief that I'm able to finish this issue in time. |
I'm not sure I could start the work ASAP. I think the task can be assigned to other contributors first if they have big interests in it. I'm also glad to provide the knowledge of StarRocks if needed in discussion, review or test. WDYT? @bowenliang123 |
Let's assign this task to both @phionex0571 @banmoy first. Also cc @zhaomin1423, the original contributor of the JDBC engine. They may need some guidance for this task. Thanks to all. |
Thanks you all, StarRocks is excellent and used widely, look forward. |
@bowenliang123 @banmoy Hi, I've finished almost all the coding work and I have a question about StarRocks version in test cases. There're |
The latest stable released version of StarRocks is 3.1.x, which is reasonable to be tested with. |
@phionex0571 Is it possible to make the unit tests run against the latest several StarRocks versions, such as 2.5, 3.0, and 3.1? So that we can tell users in the doc which version of StarRocks is supported, just like Spark/Flink/Trino? I think test cases should be same among different versions, but just use the specific docker image for each version. |
@banmoy It's not suggested to tested on multiple versions of StarRocks. As for other engines for Spark/Flink/Trino, we tested on different matrix combinations as Kyuubi use different version of API on these engines and has dedicated engine implementation and adaptations. |
@phionex0571 Hi, is there any progress on this task? |
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#5404 ## Describe Your Solution 🔧 - Introduce StarRocks support in JDBC Engine - Adding dialects and tests for StarRocks - Tested with StarRocks 3.x official open-sourced version docker image, with a mini cluster with FE and BE setup. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 Supported StarRocks in JDBC engine. #### Related Unit Tests Add tests of `StarRocksOperationSuite`, `StarRocksOperationWithEngineSuite`, `StarRocksSessionSuite` and `StarRocksStatementSuite`. --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [ ] Pull request title is okay. - [ ] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes apache#5882 from bowenliang123/jdbc-sr. Closes apache#5404 54927d3 [Bowen Liang] update 5b1bbf7 [Bowen Liang] update doc f01da74 [Bowen Liang] update StarRocksStatementSuite 1018bc9 [Bowen Liang] MySQL8ConnectionProvider 59cba95 [Bowen Liang] simplify StarRocksDialect 4bf55bb [Bowen Liang] simplify StarRocksTRowSetGenerator c857224 [Bowen Liang] jdbc starrocks Authored-by: Bowen Liang <liangbowen@gf.com.cn> Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
Code of Conduct
Search before creating
Mentor
Skill requirements
Background and Goals
Currently, Kyuubi supports JDBC engines with limited dialects, and we can extend the dialects to support StarRocks, which is an open-source and high-performance analytical database.
Reference https://www.bilibili.com/video/BV1UT411m7LR
Implementation steps
Additional context
No response
The text was updated successfully, but these errors were encountered: