Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Change default metrics reporter to prometheus #5381

Closed
2 of 3 tasks
pan3793 opened this issue Oct 8, 2023 · 3 comments
Closed
2 of 3 tasks

[TASK][EASY] Change default metrics reporter to prometheus #5381

pan3793 opened this issue Oct 8, 2023 · 3 comments
Assignees
@zhaohehuhu
Labels
hacktoberfest hacktoberfest-accepted

Comments

@pan3793
Copy link
Member

pan3793 commented Oct 8, 2023

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.

Skill requirements

  • Basic knowledge of Apache Kyuubi and Scala

Background and Goals

Prometheus becomes de-faco metrics standard these days, it's better to change the default value of kyuubi.metrics.reporters from JSON to PROMETHEUS

Implementation steps

  • Change the default value of "kyuubi.metrics.reporters" defined in MetricsConf
  • Regenerate the docs
  • Update migration guide to mention the change
  • Fix failed UT if any

Additional context

No response
@pan3793 pan3793 mentioned this issue Oct 8, 2023
Closed
3 tasks
@ITzhangqiang
Copy link
Contributor

ITzhangqiang commented Oct 10, 2023 •
edited
Loading

Can you assign this issue to me? I plan to complete it by October 25th. @pan3793

@pan3793
Copy link
Member Author

pan3793 commented Oct 10, 2023

@ITzhangqiang this is almost done via #5344

@zhaohehuhu
Copy link
Contributor

I understand this task and almost make it done.

pan3793 added a commit that referenced this issue Oct 16, 2023
@zhaohehuhu @pan3793
[KYUUBI #5381] Change the default metrics reporter to Prometheus
3ab086a 
### _Why are the changes needed?_

Close #5381

change default metrics reporter to prometheus since Kyuubi 1.8

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

Closes #5344 from zhaohehuhu/Improvement-0928.

Closes #5381

84f4c82 [hezhao2] reset METRICS_REPORTERS for test case
b9ee5f7 [Cheng Pan] Update kyuubi-server/src/test/scala/org/apache/kyuubi/events/handler/ServerJsonLoggingEventHandlerSuite.scala
86165a6 [Cheng Pan] Update kyuubi-server/src/test/scala/org/apache/kyuubi/events/handler/ServerJsonLoggingEventHandlerSuite.scala
a3605b6 [hezhao2] set METRICS_PROMETHEUS_PORT to 0 for test cases
f1a4d28 [hezhao2] restore version number for kyuubi.metrics.reporters in doc
dae40e1 [hezhao2] change default metrics reporter to prometheus

Lead-authored-by: hezhao2 <hezhao2@cisco.com>
Co-authored-by: Cheng Pan <pan3793@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 4bb67bd)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaohehuhu zhaohehuhu

Labels
hacktoberfest hacktoberfest-accepted
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #5381] Change the default metrics reporter to Prometheus zhaohehuhu/incubator-kyuubi
4 participants
@yaooqinn @pan3793 @zhaohehuhu @ITzhangqiang