Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][EASY] Add an optional comment field to the authz specs for better recognition #5255

Closed
3 of 4 tasks
yaooqinn opened this issue Sep 5, 2023 · 5 comments
Closed
3 of 4 tasks
Assignees

Comments

@yaooqinn
Copy link
Member

yaooqinn commented Sep 5, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Some plans may come from third parties, and we can provide some comment there

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@pan3793 pan3793 changed the title [Improvement] Add an optional comment field to the authz specs for better recognition [TASK][EASY] Add an optional comment field to the authz specs for better recognition Oct 11, 2023
@davidyuan1223
Copy link
Contributor

looks this issue i can fix, and could you desc more info?

@yaooqinn
Copy link
Member Author

yaooqinn commented Nov 6, 2023

What other information would you like me to provide?

@davidyuan1223
Copy link
Contributor

What other information would you like me to provide?

my problem, i want know what we want to provide comment, i found there only extractor's implementations have special third parties,we wanna provide comment for the special extractor?

@yaooqinn
Copy link
Member Author

yaooqinn commented Nov 7, 2023

The command descs are curated in tests, so it's hard for users to get such information in runtime, especially encountering errors. I‘d like to add an extra field called 'comment' to these descs, it can be used as a part of the error messages and log for debugging.

@davidyuan1223
Copy link
Contributor

The command descs are curated in tests, so it's hard for users to get such information in runtime, especially encountering errors. I‘d like to add an extra field called 'comment' to these descs, it can be used as a part of the error messages and log for debugging.

get, i think i can fix

davidyuan1223 added a commit to davidyuan1223/kyuubi that referenced this issue Nov 15, 2023
davidyuan1223 added a commit to davidyuan1223/kyuubi that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
3 participants