Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix typo and style issue on GitHub issue template and website #2315

Closed
2 of 3 tasks
sebbASF opened this issue Apr 10, 2022 · 4 comments · Fixed by apache/kyuubi-website#60
Closed
2 of 3 tasks

[DOCS] Fix typo and style issue on GitHub issue template and website #2315

sebbASF opened this issue Apr 10, 2022 · 4 comments · Fixed by apache/kyuubi-website#60
Labels
kind:documentation Documentation is a feature!

Comments

@sebbASF
Copy link

sebbASF commented Apr 10, 2022 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Which parts of the documentation do you think need improvement?

No response

Affects Version(s)

ALL

Imporving the documentation

  1. Fix the header for this section: "Imporving the documentation" => "Improving the documentation"

  2. Fix the download page. HTML attribute values should be quoted.
    e.g. href=/mailing_lists.html => href="/mailing_lists.html"
    Similarly for all other values.

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@sebbASF sebbASF added the kind:documentation Documentation is a feature! label Apr 10, 2022
yangrong688 added a commit to yangrong688/kyuubi that referenced this issue Apr 11, 2022
@yangrong688
[DOCS] Change "Imporving the documentation" to "Improving the documen…
e76fe65 
…tation"

try to fix apache#2315 problem 1
@yangrong688 yangrong688 mentioned this issue Apr 11, 2022
Closed
3 tasks
@pan3793 pan3793 changed the title [DOCS] [DOCS] Fix typo and style issue on GitHub issue template and website Apr 11, 2022
@pan3793
Copy link
Member

pan3793 commented Apr 11, 2022

Fix the download page. HTML attribute values should be quoted.
e.g. href=/mailing_lists.html => href="/mailing_lists.html"
Similarly for all other values.

Hi @yangrong688, I saw you send a PR to fix the issue 1, and the issue 2 should be fixed in https://github.com/apache/incubator-kyuubi-website, would you like to fix it?

@yangrong688
Copy link
Contributor

@pan3793 I'd like to have a try.

@yangrong688 yangrong688 mentioned this issue Apr 11, 2022
Merged
pan3793 pushed a commit that referenced this issue Apr 11, 2022
@yangrong688 @pan3793
[KYUUBI #2316] [DOCS] Fix typo in GitHub issue template
d3d73c6 
### _Why are the changes needed?_

Partially fix #2315 problem 1

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2316 from yangrong688/patch-1.

Closes #2316

e76fe65 [yangrong688] [DOCS] Change "Imporving the documentation" to "Improving the documentation"

Authored-by: yangrong688 <70557521+yangrong688@users.noreply.github.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793
Copy link
Member

pan3793 commented Apr 11, 2022

Thanks @sebbASF for reporting the issues, and thanks @yangrong688 for fixing!

@sebbASF
Copy link
Author

sebbASF commented Apr 11, 2022

Thanks for the very quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:documentation Documentation is a feature!
Projects
None yet
Milestone
No milestone
3 participants
@sebbASF @pan3793 @yangrong688