Skip to content

Commit

Permalink
[KYUUBI #1498] Support operation log for ExecuteScala
Browse files Browse the repository at this point in the history
### _Why are the changes needed?_
close #1498

Pass scala repl output to operation log.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2234 from cxzl25/KYUUBI-1498.

Closes #1498

21ec282 [sychen] add prefix
fb2ee3c [sychen] pass scala repl output to operation log
8f36a52 [sychen] pass scala repl output to operation log

Authored-by: sychen <sychen@trip.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
  • Loading branch information
cxzl25 authored and ulysses-you committed Mar 29, 2022
1 parent fe3ece1 commit ea0121b
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ class ExecuteScala(
if (result != null) {
new ArrayFetchIterator[Row](result.collect())
} else {
// TODO (#1498): Maybe we shall pass the output through operation log
// but some clients may not support operation log
new ArrayFetchIterator[Row](Array(Row(repl.getOutput)))
val output = repl.getOutput
info("scala repl output:\n" + output)
new ArrayFetchIterator[Row](Array(Row(output)))
}
}
case Error =>
Expand Down

0 comments on commit ea0121b

Please sign in to comment.