Skip to content

refactor(tdigest): convert the flags for reverse in TDigest::Rank to a compile-time argument #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

refactor(tdigest): convert the flags for reverse in TDigest::Rank to a compile-time argument #3268

wants to merge 1 commit into from
+171 −177

Conversation

@donghao526
Copy link
Contributor

@donghao526 donghao526 commented Nov 20, 2025

The reverse flag in the current TDigest::Rank implementation is a runtime value. Therefore, it should be converted to a compile-time argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LindaSummer LindaSummer Awaiting requested review from LindaSummer

@git-hulk git-hulk Awaiting requested review from git-hulk

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@donghao526