feat(search): support the FT.TAGVALS command #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
PragmaTwice
reviewed
Oct 1, 2024
PragmaTwice
reviewed
Oct 1, 2024
PragmaTwice
reviewed
Oct 1, 2024
PragmaTwice
reviewed
Oct 1, 2024
PragmaTwice
reviewed
Oct 2, 2024
PragmaTwice
reviewed
Oct 3, 2024
PragmaTwice
reviewed
Oct 3, 2024
Member
PragmaTwice
left a comment
PragmaTwice
left a comment
There was a problem hiding this comment.
The rest looks good to me.
Co-authored-by: Twice <twice@apache.org>
PragmaTwice
reviewed
Oct 3, 2024
…vrocks into ft-tagvals-command
Contributor
Author
|
@PragmaTwice Commited to change. Should be good to run workflow |
Member
|
Could you check the CI failure to see if it can be fixed? |
Contributor
Author
|
@PragmaTwice CI, should be fixed. It was just incorrect return values for type mismatch. |
|
PragmaTwice
approved these changes
Oct 4, 2024
PragmaTwice
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FT.TagVals for search + tests