Skip to content

Move the nightly docker image organization to the apache#1073

Merged
tisonkun merged 1 commit intoapache:unstablefrom
git-hulk:change-dockerhub-org-to-apache
Nov 4, 2022
Merged

Move the nightly docker image organization to the apache#1073
tisonkun merged 1 commit intoapache:unstablefrom
git-hulk:change-dockerhub-org-to-apache

Conversation

@git-hulk
Copy link
Member

@git-hulk git-hulk commented Nov 4, 2022

This closes #1019

@git-hulk git-hulk marked this pull request as ready for review November 4, 2022 04:15
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether we should update the secret for uploading permissions of apache org.

Request changes to prevent accidental merge. If CI passed then we can merge.

@git-hulk
Copy link
Member Author

git-hulk commented Nov 4, 2022

I don't know whether we should update the secret for uploading permissions of apache org.

Request changes to prevent accidental merge. If CI passed then we can merge.

It should be fine since the old docker user/token is created by my personal account which also have applied the permission to push to the apache organization.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@git-hulk cool! Approved and merging...

@tisonkun tisonkun merged commit 9665bbf into apache:unstable Nov 4, 2022
xiaobiaozhao pushed a commit to xiaobiaozhao/kvrocks that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move docker image to the Apache organization

3 participants