Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-3077 - Add pac4j.cookie.max.age param #972

Merged
merged 3 commits into from
Jan 8, 2025
Merged

KNOX-3077 - Add pac4j.cookie.max.age param #972

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4578b5
KNOX-3077 - Add pac4j.cookie.max.age param
moresandeep Dec 12, 2024
de3d5fc
KNOX-3077 - Review changes
moresandeep Dec 13, 2024
e8f4799
Fix NullPointer Exceptions and 503 inactive topology (via Phil Zampino)
moresandeep Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
KNOX-3077 - Review changes
  • Loading branch information
@moresandeep
moresandeep committed Dec 13, 2024
commit de3d5fc0494afb4896c12c08bdeb148bbe691836
4 changes: 2 additions & 2 deletions ...urity-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public class Pac4jDispatcherFilter implements Filter, SessionInvalidator {
public static final String PAC4J_COOKIE_MAX_AGE = "pac4j.cookie.max.age";

/* default value is same is KNOXSSO token ttl default */
public static final int PAC4J_COOKIE_MAX_AGE_DEFAULT = -1;
private static final String PAC4J_COOKIE_MAX_AGE_DEFAULT = "-1";

private CallbackFilter callbackFilter;

Expand Down Expand Up @@ -223,7 +223,7 @@ public void init( FilterConfig filterConfig ) throws ServletException {
/* do we need to exclude custom attributes? */
setSessionStoreConfig(filterConfig, PAC4J_SESSION_STORE_EXCLUDE_CUSTOM_ATTRIBUTES, PAC4J_SESSION_STORE_EXCLUDE_CUSTOM_ATTRIBUTES_DEFAULT);
/* add cookie expiry */
setSessionStoreConfig(filterConfig, PAC4J_COOKIE_MAX_AGE, Long.toString(PAC4J_COOKIE_MAX_AGE_DEFAULT));
setSessionStoreConfig(filterConfig, PAC4J_COOKIE_MAX_AGE, PAC4J_COOKIE_MAX_AGE_DEFAULT);
//decorating client configuration (if needed)
PAC4J_CLIENT_CONFIGURATION_DECORATOR.decorateClients(clients, properties);
}
Expand Down
Loading