Skip to content

Conversation

@Kimahriman
Copy link

@Kimahriman Kimahriman commented Jul 25, 2025

(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)

What changes were proposed in this pull request?

Remove trailing slash is YARN proxy rewrite rules which now cause issues with Spark 4.0.0 UI. I don't see any other rewrite rules for YARN including a trailing slash, so not sure why the proxy ones ever needed to.

(Please fill in changes proposed in this fix)

How was this patch tested?

Manual tested locally.

Before:

Screenshot 2025-07-25 at 7 23 42 AM

After:

Screenshot 2025-07-25 at 7 31 27 AM

Please review Knox Contributing Process before opening a pull request.

@Kimahriman Kimahriman force-pushed the yarn-proxy-trailing-slash branch from 01c9944 to 6f24a53 Compare July 25, 2025 14:32
@smolnar82 smolnar82 assigned smolnar82 and Kimahriman and unassigned smolnar82 Jul 25, 2025
@smolnar82 smolnar82 requested a review from moresandeep July 25, 2025 14:43
@smolnar82
Copy link
Contributor

Hi @moresandeep !

Whenever you have time, can you please review this change?

Thanks!

@smolnar82
Copy link
Contributor

@Kimahriman - I see you modified both 2.7.0 and 3.0.0 too. Does it mean you tested both versions?

@Kimahriman
Copy link
Author

@Kimahriman - I see you modified both 2.7.0 and 3.0.0 too. Does it mean you tested both versions?

3.0.0 is for the V2 UI, and yeah confirmed it also has the issue and this also fixes in the same way.

@moresandeep
Copy link
Contributor

@Kimahriman looks like this is for newer version of Yarn instead of updating 3.0.0 can you create a new version 4.0.0 and make changes there? We want to make sure that older version work as well and there is no regression.

@Kimahriman
Copy link
Author

It's not related to the version of YARN, it's a new version of spark that hits an edge case that has probably always existed. I don't see why you would ever want to insert a trailing slash when it didn't already exist, and I don't see any of the other rewrites for either of those services that do the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants