KAFKA-20130: Move RecordValidationStats to storage module #21418
+28
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Feb 6, 2026
| this.conversionTimeNanos = conversionTimeNanos; | ||
| } | ||
|
|
||
| public RecordValidationStats() { |
Member
There was a problem hiding this comment.
Since this constructor is only used by EMPTY, can we remove it and just use the main one?
public static final RecordValidationStats EMPTY = new RecordValidationStats(0, 0, 0);| } | ||
|
|
||
| @Override | ||
| public String toString() { |
Member
There was a problem hiding this comment.
we could use the generated toString instead
chia7712
reviewed
Feb 10, 2026
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.common.record; |
Member
There was a problem hiding this comment.
Could you move it to org.apache.kafka.storage.internals.log?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to storage and turned into a record for immutability. Removed
add()because it didn't seem to be used.