MINOR: Add project icon for IntelliJ IDEA#20215
MINOR: Add project icon for IntelliJ IDEA#20215Pankraz76 wants to merge 1 commit intoapache:trunkfrom
IntelliJ IDEA#20215Conversation
|
kindly request your eyes on this assuming its a low hanging fruit, thanks. |
m1a2st
left a comment
There was a problem hiding this comment.
Thanks for the patch! Could you update the PR title to use MINOR: as the prefix?
IntelliJ IDEAIntelliJ IDEA
This comment was marked as resolved.
This comment was marked as resolved.
|
@Pankraz76 thanks for your contribution. I don't quite understand the purpose of having the icon in Intellij. Could you share your thoughts with me? |
|
Thanks for the response. It’s just a nice little gimmick to improve the look and feel. It helps (me) quickly recognize projects when switching between them. I can’t say for sure if it’s good for this project. The only feedback I’ve received so far has been positive, and these changes have always been accepted. The only downside is having IDE-specific configs in the repo, which is generally avoided. In this case, all the projects make an exception to support this. |
|
I just noticed this by accident as well so I like to spread the learning:
|
|
So you thing this is any addition to the project? If not no problem, will close then. |
|
i can confirm no one cares about the code quality at all, facing the masses of unused declaration and flaws around. Good luck. |
IntelliJ IDEAelastic/elasticsearch#131427