Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18828: Update share group metrics per new init and call mechanism. #18962

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

smjn
Copy link
Contributor

@smjn smjn commented Feb 19, 2025

  • Due to recent changes in the way group count metrics are initialized and updated, the current share group count code has become obsolete as well as non-functional.
  • The update method for the share group count which should be called from ShareGroup cannot be called either. This is because the constructor has been changed to NOT accept the GroupCoordinatorShardMetrics ref.
  • In this PR, we remedy the situation by bringing share group count code at par with consumer and streams groups.
  • Additionally the metric name for share groups with group state attributes was not aligned with streams and consumer groups as mentioned in KAFKA-17367: Share coordinator impl. Broker side code. [2/N] #17011 (comment). This PR aligns them too.

Ref:
KAFKA-18655: Implement the consumer group size counter with scheduled task (#18717)

Screenshot 2025-02-19 at 4 49 46 PM

@github-actions github-actions bot added the triage PRs from the community label Feb 19, 2025
@apoorvmittal10
Copy link
Collaborator

apoorvmittal10 commented Feb 19, 2025

@smjn While you are fixing the group-count can you please also take at following conversation and add the minor change in the PR. We shall correct the KIP as well later.

@AndrewJSchofield AndrewJSchofield removed the triage PRs from the community label Feb 19, 2025
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. lgtm. I have updated the KIP accordingly.

@AndrewJSchofield AndrewJSchofield merged commit c89fd2b into apache:trunk Feb 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved KIP-932 Queues for Kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants