DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" #18800
+58
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GraphNode "keyChangingOperation"
|
Hi, @mjsax |
|
Thanks for this draft -- might take a few days until I find time to take a look. |
appchemist
commented
Feb 5, 2025
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java
Outdated
Show resolved
Hide resolved
… GraphNode "keyChangingOperation" - refactor to re-use getKeyChangingParentNode - refactor to GraphNode
|
Hi, @mjsax After Analyzing the cause, I'll request the review again However, I would appreciate it if you could take a look at the following comment when you have time. |
… GraphNode "keyChangingOperation" - refactor
… GraphNode "keyChangingOperation" - refactor GraphNode
|
@ mjsax If the POC is worth applying, I'll resolve the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR is a POC.
For now, I only focused on modifying
KStreamImpl.repartitionRequiredto replace it withGraphNode.keyChangingOperation.So I'll be working on it further to make sure it's the right fix and need to write some test code.
Committer Checklist (excluded from commit message)