Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17693: Remove testEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion #17456

Conversation

mingyen066
Copy link
Contributor

@mingyen066 mingyen066 commented Oct 10, 2024

Remove testEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion

The ticket description mentioned that testListOffsetsRequestOldestVersion should be moved to the Java ListOffsetRequestTest, which was already completed in #17100 , so no additional changes are needed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added tests Test fixes (including flaky tests) clients small Small PRs labels Oct 10, 2024
Copy link
Collaborator

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingyen066 Could you please also remove versionInfo?

@mingyen066
Copy link
Contributor Author

@chia7712 Of course, the variable versionInfo has been removed.

@chia7712 chia7712 merged commit 1e5b6b8 into apache:trunk Oct 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved clients small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants