-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-17558: Remove parameterization from streams integration tests #17315
Open
zzzk1
wants to merge
3
commits into
apache:trunk
Choose a base branch
from
zzzk1:KAFKA-17558
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
reviewed
Oct 1, 2024
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
...test/java/org/apache/kafka/streams/integration/JoinGracePeriodDurabilityIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
...ms/src/test/java/org/apache/kafka/streams/integration/ResetPartitionTimeIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
...src/test/java/org/apache/kafka/streams/integration/SuppressionDurabilityIntegrationTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the PR. Made a pass.
zzzk1
changed the title
KAFKA-17558: Remove
KAFKA-17558: Remove parameterization from streams integration tests
Oct 1, 2024
exactly-once
in stream integration tests
mjsax
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. -- One more comment.
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
Outdated
Show resolved
Hide resolved
I am not sure why the Smoke Test failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fullow up #17110
exactly-once
value included in parameterizedResetPartitionTimeIntegrationTest
RocksDBMetricsIntegrationTest.java
Committer Checklist (excluded from commit message)