JSPWIKI-1205 adjusts the handling for too large file attachments. #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s change, while it addresses the issue, might cause a new issue whereby updatlong an extremely large file might cause OOM errors since the commons file uploader parses and buffers the whole http request. And the way the upload page works, it is not possible to get the correct redirect url without parsing the request. unformately, i don't think there's a way to add an http header to multipart form post from javascript.. open to other opinions on this
… that provides a list of server installed plugins and alters the UI to support fetching and displaying them. Alters the Plugin API definition to have two additional methods with default implementations that should hopefully support backwards compat Alters the PluginManager API to include a getDiscoveredPlugins Alters a few of the javascript mechanisms to get the plugin list ti display with the snip suggestions. This seems to cause a duplicate of the IfPlugin Adds a test hello world type plugin to verify this functionality
…endpoint that provides a list of server installed plugins and alters the UI to support fetching and displaying them." This reverts commit 0df4e22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root issue is that when uploading a large file (larger than the configured max), the browser gets a 302 redirect, however in my experience, it just displays a connection closed message. The response looks like it should be ok otherwise.
Anyhow, the fix is to ensure that the uploader rejects the files that are too big and redirects to the upload attachment page by simply moving the logic around in the servlet.
This change, while it addresses the issue, might cause a new issue whereby uploading an extremely large file might cause OOM errors since the commons file uploader parses and buffers the whole http request. And the way the upload page works, it is not possible to get the correct redirect url without parsing the request. unfortunately, i don't think there's a way to add an http header to multipart form post from javascript. open to other opinions on this or if the risk is worth it.