Skip to content

Align ssl props / Enable setting cipher suite (WIP) #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2021

Conversation

pmouawad
Copy link
Contributor

Description

  • Use https.cipherSuites property for HC4
  • Use https.cipherSuites and https.socket.protocols in Proxy

Motivation and Context

Clarification of use.
Allow fine grain control during recording.

How Has This Been Tested?

Manual testing and debugging.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
Not Found
…https.cipherSuites as the latter is documented

Use https.cipherSuites, https.socket.protocols in Proxy (HTTP(S) Test Script Recorder)
@codecov-commenter
Copy link

Codecov Report

Merging #677 (9717ffd) into master (3c23246) will increase coverage by 0.25%.
The diff coverage is 27.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #677      +/-   ##
============================================
+ Coverage     55.40%   55.66%   +0.25%     
- Complexity    10230    10283      +53     
============================================
  Files          1047     1049       +2     
  Lines         64518    64565      +47     
  Branches       7317     7321       +4     
============================================
+ Hits          35749    35937     +188     
+ Misses        26271    26105     -166     
- Partials       2498     2523      +25     
Impacted Files Coverage Δ
...AddUndoableEditListenerPropertyChangeListener.java 0.00% <0.00%> (ø)
.../org/apache/jorphan/gui/ui/DefaultUndoManager.java 0.00% <0.00%> (ø)
...a/org/apache/jmeter/protocol/http/proxy/Proxy.java 0.00% <0.00%> (ø)
...ava/org/apache/jorphan/gui/ui/TextComponentUI.java 26.82% <18.75%> (+26.82%) ⬆️
.../main/java/org/apache/jmeter/util/JMeterUtils.java 54.23% <71.42%> (+2.86%) ⬆️
...va/org/apache/jmeter/gui/util/JSyntaxTextArea.java 61.53% <100.00%> (+0.42%) ⬆️
...sampler/hc/LazyLayeredConnectionSocketFactory.java 94.44% <100.00%> (+8.08%) ⬆️
.../apache/jmeter/timers/ConstantThroughputTimer.java 54.63% <0.00%> (-4.13%) ⬇️
...main/java/org/apache/jmeter/config/CSVDataSet.java 78.81% <0.00%> (-3.39%) ⬇️
...e/jmeter/save/converters/TestElementConverter.java 75.55% <0.00%> (-3.02%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062190a...9717ffd. Read the comment docs.

@pmouawad pmouawad merged commit c98be3f into apache:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants