Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ-64800: correcting plugin action components' resource key usages #631

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

woonsan
Copy link
Contributor

@woonsan woonsan commented Oct 11, 2020

Description

Motivation and Context

In the current version (v5.3), some child menu items under the tools fail to display translated labels when switching to other languages or switching back to English again.

Find more description in the issue ticket: https://bz.apache.org/bugzilla/show_bug.cgi?id=64800

How Has This Been Tested?

Clean build; confirm unit tests succeeded.
And test the GUI menus manually while switching to French or Korean and back to English.

Screenshots (if appropriate):

Now translated menu labels are displayed when switching to French or Korean or back to English, fixing the problem in the screenshot attachment in https://bz.apache.org/bugzilla/show_bug.cgi?id=64800.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Even if the PR has some resource key changes, I don't think it breaks anything because:

  • Those submenus under the Tools have never been displayed correctly in v5.3, in French, or even in English when switching it back to English.
  • Other language translations other than French have never had translated messages for those 4 action menu items.
  • Therefore, changing the resource keys for those 4 actions in both Java code and those existing resource files do not seem to break anything.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@codecov-io
Copy link

Codecov Report

Merging #631 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #631      +/-   ##
============================================
- Coverage     55.29%   55.28%   -0.02%     
+ Complexity    10089    10087       -2     
============================================
  Files          1038     1038              
  Lines         63858    63858              
  Branches       7229     7229              
============================================
- Hits          35311    35304       -7     
- Misses        26051    26060       +9     
+ Partials       2496     2494       -2     
Impacted Files Coverage Δ Complexity Δ
...r/gui/action/ExportTransactionAndSamplerNames.java 33.33% <100.00%> (ø) 7.00 <0.00> (ø)
...n/java/org/apache/jmeter/gui/HtmlReportAction.java 76.19% <100.00%> (ø) 7.00 <0.00> (ø)
.../main/java/org/apache/jmeter/gui/HtmlReportUI.java 47.24% <100.00%> (ø) 8.00 <1.00> (ø)
...e/jmeter/gui/action/CompileJSR223TestElements.java 40.00% <100.00%> (ø) 7.00 <0.00> (ø)
...va/org/apache/jmeter/gui/action/SchematicView.java 34.42% <100.00%> (ø) 7.00 <0.00> (ø)
...otocol/http/gui/action/ParseCurlCommandAction.java 54.41% <100.00%> (ø) 80.00 <0.00> (ø)
...ter/protocol/http/proxy/SamplerCreatorFactory.java 27.90% <0.00%> (-13.96%) 4.00% <0.00%> (-1.00%)
...ter/protocol/http/proxy/DefaultSamplerCreator.java 52.74% <0.00%> (-0.55%) 27.00% <0.00%> (-1.00%)
...n/java/org/apache/jmeter/reporters/Summariser.java 85.49% <0.00%> (ø) 18.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42abaa3...dec2d50. Read the comment docs.

@pmouawad pmouawad merged commit 041eb89 into apache:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants